Re: [libvirt] PATCH: 25/25: Support ac97 sound card

["Daniel P. Berrange" <berrange redhat com>]

On Tue, Mar 10, 2009 at 11:46:13AM +0100, Pritesh Kothari wrote:
> Hi All,
> 
> Small patch for updating the schema file and testcase for the same:
> 
> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
> index 2e2e408..107215c 100644
> --- a/docs/schemas/domain.rng
> +++ b/docs/schemas/domain.rng
> @@ -874,6 +874,7 @@
>            <value>sb16</value>
>            <value>es1370</value>
>            <value>pcspk</value>
> +          <value>ac97</value>
>          </choice>
>        </attribute>
>      </element>

ACK, 

> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-sound.xml 
> b/tests/qemuxml2argvdata/qemuxml2argv-sound.xml
> index cc85c53..8c33e6c 100644
> --- a/tests/qemuxml2argvdata/qemuxml2argv-sound.xml
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-sound.xml
> @@ -21,5 +21,6 @@
>      <sound model='pcspk'/>
>      <sound model='es1370'/>
>      <sound model='sb16'/>
> +    <sound model='ac97'/>
>    </devices>
>  </domain>

If you change this file, you'll also need to change the corresponding
file tests/qemuxml2argvdata/qemuxml2argv-sound.args, which is the 
command line ARGV associated with that XML. Should merely need to
add ',ac97' into the appropriate place.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|