[libvirt] Re: [PATCH][take2] storage: fix disregarding specified owner/group permissions

[Ryota Ozaki <ozaki ryota gmail com>]

Hi Daniel,

On Fri, Mar 13, 2009 at 5:15 AM, Daniel Veillard <veillard redhat com> wrote:
> On Fri, Mar 13, 2009 at 12:43:12AM +0900, Ryota Ozaki wrote:
>> Hi,
>>
>> The changes since the last patch are,
>> - pass a default value of 'mode' permission to virStorageDefParsePerms
>> - fix regression
>>   - I missed setting permission values in the case of that there is not
>>     <permissions> element
>
>  Cool, thanks, this looks fine ! I just changed 2 small things
>   - an extra const which was spotted by "make syntaxcheck"
>   - I canged the mode_t to int, since we currently use mode_t only
>     in code compiled on Linux I was afraid of introducting a
>     protability problem, and also the structure struct _virStoragePerms
>     defines mode as int. If we were to fix int -> mode_t this should
>     probably done more uniformly and as a separate patch.

I see.

>
>  Applied and commited !

Thanks for applying!
  ozaki-r

>
>    thanks a lot !
>
> Daniel
>
> --
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/
>