[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] Fix test driver domain save



Saving a domain via the test driver currently locks up, since the save
command is calling out to another public driver method. The attached
patch fixes this.

Thanks,
Cole
diff --git a/src/test.c b/src/test.c
index 226fe2e..2be874f 100644
--- a/src/test.c
+++ b/src/test.c
@@ -1172,8 +1172,6 @@ cleanup:
     return ret;
 }
 
-static char *testDomainDumpXML(virDomainPtr domain, int flags);
-
 #define TEST_SAVE_MAGIC "TestGuestMagic"
 
 static int testDomainSave(virDomainPtr domain,
@@ -1196,7 +1194,10 @@ static int testDomainSave(virDomainPtr domain,
         goto cleanup;
     }
 
-    xml = testDomainDumpXML(domain, 0);
+    xml = virDomainDefFormat(domain->conn,
+                             privdom->def,
+                             VIR_DOMAIN_XML_SECURE);
+
     if (xml == NULL) {
         virReportSystemError(domain->conn, errno,
                              _("saving domain '%s' failed to allocate space for metadata"),

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]