[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Parse qemu config before SecurityInit



On Fri, Mar 13, 2009 at 05:07:33PM -0400, Cole Robinson wrote:
> We aren't parsing qemu.conf before initializing the security driver, yet
> the config contains relevant security options. The attached patch swaps
> the ordering, which fixes things for me.

ACK

Daniel

> diff --git a/src/qemu_driver.c b/src/qemu_driver.c
> index e73bd3a..ed68ff4 100644
> --- a/src/qemu_driver.c
> +++ b/src/qemu_driver.c
> @@ -496,11 +496,11 @@ qemudStartup(void) {
>      if ((qemu_driver->caps = qemudCapsInit()) == NULL)
>          goto out_of_memory;
>  
> -    if (qemudSecurityInit(qemu_driver) < 0) {
> +    if (qemudLoadDriverConfig(qemu_driver, driverConf) < 0) {
>          goto error;
>      }
>  
> -    if (qemudLoadDriverConfig(qemu_driver, driverConf) < 0) {
> +    if (qemudSecurityInit(qemu_driver) < 0) {
>          goto error;
>      }
>  

> --
> Libvir-list mailing list
> Libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list


-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]