Re: [libvirt] [PATCH 1/2] OpenNebula driver, libvirt-0.6.1

[Cole Robinson <crobinso redhat com>]

Abel Míguez Rodríguez wrote:
> Hi all,
> 
> We have updated the OpenNebula Driver to libvirt version 0.6.1.
> Now, the ONE driver is build at the libvirtd daemon, that is the natural place for it.
> 
> 
> Please feel free to make any comment, to improve the driver's  coherence with libvirt's structure. 
> 
> I split the Patches in two e-mais:
> [PATCH 1/2] includes the patches to be applied to libvirt's sources and building files. 
> 
> 
> [PATCH 2/2] attached the "one driver" source files.
> 
> All
> the patches are made to be applied at the git commit: 
> "025b62" (Fix subsystem lookup for older HAL releases)
> 

Hi,

No comments specific to the patch, but it would help if the mail was
sent as plain text, not html. Many people (including some of the
maintainers) use text only mail clients. Also, at least in thunderbird
with html turned off, it messes with the formatting as shown below:

> 
> diff --git a/configure.in b/configure.in
> index 413d27c..fd75a8d 100644
> 
> --- a/configure.in
> +++ b/configure.in
> @@ -184,6 +184,8 @@ AC_ARG_WITH([openvz],
>  [  --with-openvz           add OpenVZ support (on)],[],[with_openvz=yes])
> 
> 
>  AC_ARG_WITH([lxc],
>  [  --with-lxc              add Linux Container support (on)],[],[with_lxc=yes])
> +AC_ARG_WITH([one],
> +[  --with-one              add ONE support (on)],[],[with_one=no])
>  AC_ARG_WITH([test],
> 

Thanks,
Cole