Re: [libvirt] [PATCH 2/2] VirtualBox support to libvirt

[Pritesh Kothari <Pritesh Kothari Sun COM>]

Hi Daniel,

> > I have a single template file called vbox_tmpl.c which is included
> > multiple times during compilation using some pre-processor magic, for
> > example:
>
>   I hit that last Friday while starting to review the patch an found
> that a bit strange.

I couldn't think of any other cleaner solution, if there is any suggestion 
regarding it, I can check that out.

>   That's probably worth a README in the vbox/ directory IMHO

Will do that.

>
>
> I guess Dan did a more complete review of the code than mine. One of the
> issues I had was many pieces of code licenced under the MIT Licence,
> which is compatible with the LGPL, but I must admit that if you are the
> authors of that code I would prefer just LGPL. I also saw parts which
> were MIT but allowed to relicence under LGPL, for the sake of uniformity
> I would prefer all files provided under LGPLv2 like the other parts of
> libvirt code. In a sense it's equivalent for you, but for people doing
> the legal review when trying to embbed libvirt this makes things more
> complicated. Any chance you could fix all those headers ?

I have fixed all headers to be LGPLv2.1 :)

Thanks
Pritesh