Re: [libvirt] PATCH: Support memory ballooning for QEMU

[Daniel Veillard <veillard redhat com>]

On Mon, Mar 16, 2009 at 01:00:22PM +0000, Daniel P. Berrange wrote:
> On Tue, Mar 10, 2009 at 05:39:22PM +0000, Daniel P. Berrange wrote:
> > This patch implements full support for memory ballooning in the QEMU
> > driver.
> > 
> >  - Fix qemudBuildCommandLine() to set the initial boot time VM memory 
> >    allocation based off the 'maxmem' config field.
> >  - Add call to 'qemudDomainSetMemoryBalloon' immediately at startup
> >    to make the guest balloon to initial requested allocation.
> >  - In the qemudDomainGetInfo() and qemudDomainDumpXML calls, query
> >    the monitor to find current balloon allocation and update config
> >  - Implement qemudDomainSetMemory() for running guests using the
> >    monitor balloon command
> > 
> > In all of these scenarios, if the QEMU being used is too old to support
> > the memory balloon device, the user will get a suitable error or it'll
> > report the statically defined memory allocation from boot time.
> 
> Updated, with the bugs Cole noticed fixed.

  Patch looks fine to me, maybe this should be applied now,

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/