[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [libvirt] [PATCH 1/2]: Convert internal drivers to old style struct initializers
- From: Daniel Veillard <veillard redhat com>
- To: Chris Lalancette <clalance redhat com>
- Cc: Libvirt <libvir-list redhat com>
- Subject: Re: [libvirt] [PATCH 1/2]: Convert internal drivers to old style struct initializers
- Date: Tue, 31 Mar 2009 11:40:32 +0200
On Mon, Mar 30, 2009 at 02:10:05PM +0200, Chris Lalancette wrote:
> This patch converts the internal drivers to use the old-style struct
> initializers, which kind of gives us a self-documenting TODO list for each of
> the drivers. It also fixes up some bad comments in the internal driver list.
> It does not touch the storage or network driver initializers.
Okay I agree that the ancient form is preferable, to me it allows
very easilly to spot missing features in the driver table (the
associated entry is NULL).
I reviewed the changes trying to make sure no entry point got dropped
in the rewrite, looks good and thanks also for fixing the comments,
ACK !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel veillard com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]