[libvirt] error in libvirt.py from libvirt-0.6.1 ?

Gerrit Slomma roadrunner_gs at web.de
Tue Mar 31 18:23:07 UTC 2009


Hello

Is there a paticular reason for having "def migrate" two times in 
libvirt.py?
The first occurence is on line 345 with parameters (self, dconn, flags, 
dname, uri, bandwidth)
The second occurence is on line 1102 with parameters (self, domain, 
flags, dname, uri, bandwidth)
Which one is correct?
And i am no python programmer in the least, but isn't the ret set false?
ret = libvirtmod.virDomainMigrate(domain__o, self._o, flags, dname, uri, 
bandwidth)
That doesn't correspond to the def some above this earlier.

diff /tmp/migrate_1st_occurance /tmp/migrate_2nd_occurance
1c1
<     def migrate(self, dconn, flags, dname, uri, bandwidth):
---
 >     def migrate(self, domain, flags, dname, uri, bandwidth):
31,34c31,34
<         if dconn is None: dconn__o = None
<         else: dconn__o = dconn._o
<         ret = libvirtmod.virDomainMigrate(self._o, dconn__o, flags, 
dname, uri, bandwidth)
<         if ret is None:raise libvirtError('virDomainMigrate() failed', 
dom=self)
---
 >         if domain is None: domain__o = None
 >         else: domain__o = domain._o
 >         ret = libvirtmod.virDomainMigrate(domain__o, self._o, flags, 
dname, uri, bandwidth)
 >         if ret is None:raise libvirtError('virDomainMigrate() 
failed', conn=self)




More information about the libvir-list mailing list