Re: [libvirt] [PATCH 1/3] support for "Internal" network in libvirt

[Daniel Veillard <veillard redhat com>]

On Wed, May 06, 2009 at 06:11:42PM +0200, Pritesh Kothari wrote:
> Hi All,
> 
> As discussed on the list resending the networking patch's. the patch's are as 
> below:
> 
> [PATCH 1/3]: contains support for "Internal" network in libvirt
[...]
> +    case VIR_DOMAIN_NET_TYPE_INTERNAL:
> +        if (internal == NULL) {
> +            virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s",
> +            "No <source> 'name' attribute specified with <interface type='internal'/>");

  Okay, looks fine, I just had to mark that diagnostic string for
localization as pointed out by "make syntax-check".

  The patch being standalone, applied and commited,

     thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/