Re: [libvirt] PATCH: 2/5: Remote driver / daemon implementation

[Cole Robinson <crobinso redhat com>]

Daniel P. Berrange wrote:
> On Wed, May 13, 2009 at 05:29:44PM +0200, Daniel Veillard wrote:

<snip>

>>
>>> diff -r 4f46dfd24fdb src/virsh.c
>>> --- a/src/virsh.c	Wed May 13 09:54:09 2009 -0400
>>> +++ b/src/virsh.c	Wed May 13 09:54:10 2009 -0400
>>> @@ -4189,8 +4189,8 @@ makeCloneXML(char *origxml, char *newnam
>>>  makeCloneXML(char *origxml, char *newname) {
>>>  
>>>      xmlDocPtr doc;
>>> -    xmlXPathContextPtr ctxt;
>>> -    xmlXPathObjectPtr obj;
>>> +    xmlXPathContextPtr ctxt = NULL;
>>> +    xmlXPathObjectPtr obj = NULL;
>>>      xmlChar *newxml = NULL;
>>>      int size;
>>   Sounds a completely different patch to push independantly, and
>> yes that's needed ACK ! for an immediate push
> 
> Yes, Cole was already looking at this.
> 

I just pushed the above change.

Thanks,
Cole