Re: [libvirt] PATCH: Don't set ifname or script args for QEMU tap devices

[Daniel Veillard <veillard redhat com>]

On Wed, May 27, 2009 at 01:33:49PM +0100, Daniel P. Berrange wrote:
> When running QEMU with a type=bridge or type=network  interface config,
> we pass a pre-created  TAP device file descriptor, eg
> 
>   -net tap,fd=17,script=,vlan=0,ifname=vnet0
> 
> The ifname and script args have always been ignored by all QEMU versions
> we support. Latest QEMU will now error out if they are set. So this
> patch drops those two redundant options.  NB, then are still set for
> type=ethernet inteface configs, because in that config we're not creating
> a TAP device.
> 
>   -net tap,fd=17,vlan=0 
> 
> There is no impact on test cases, because live TAP devices is something
> that you can exercise in the test cases.

  This is what Anthony comented on if I understand, ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/