Re: [libvirt] PATCH: Fix double-free in daemon after client connection drop

[Daniel Veillard <veillard redhat com>]

On Fri, May 29, 2009 at 01:50:06PM +0100, Daniel P. Berrange wrote:
> If a client drops a connection unexpectedly there is a possiblity of a 
> double free in the daemon if using SASL or TLS. This is because there
> is possibility for poll() on the socket, returns POLLIN and POLLHUP/ERR
> at the same time. Both the POLLIN and POLLHUP handling code will attempt
> to use qemudDispatchClientFailure to mark the client as dieing, doing a
> double free. It is hard to avoid this potential double-invocation of
> the cleanup function, so it is preferrable to make it safe

  Yup, patch makes sense, ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/