[libvirt] [PATCH] Fix virInterfaceIpDefPtr leak during virInterfaceIpDefFree().

[Daniel P. Berrange]

On Mon, Nov 02, 2009 at 08:34:50AM -0500, Laine Stump wrote:
> This is the only update to the patchset already sent. All other problems
> were either in netcf code, or will be cleaned up later.
> 
> A patch has been sent to netcf-devel which, when applied, allows make
> check of libvirt plus the patch series to complete with no errors.
> 
> There is still one issue, affecting bond interfaces, which is not
> revealed by make check. I'll describe that in a separate email.
> ---
>  src/conf/interface_conf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c
> index fc18eba..31af957 100644
> --- a/src/conf/interface_conf.c
> +++ b/src/conf/interface_conf.c
> @@ -58,6 +58,7 @@ void virInterfaceIpDefFree(virInterfaceIpDefPtr def) {
>      if (def == NULL)
>          return;
>      VIR_FREE(def->address);
> +    VIR_FREE(def);
>  }

ACK

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|