Re: [libvirt] [PATCH 1/2] Improve virDomain{Attach, Detach}Device documentation

[Daniel Veillard <veillard redhat com>]

On Mon, Nov 16, 2009 at 04:06:41PM -0700, Jim Fehlig wrote:
> virDomain{Attach,Detach}Device is only permitted on active
> domains.  Explicitly state this restriction in the API
> documentation.

  Well, actually I'm not sure it's true. For exemple the
XML xen driver has an implementation for inactive Xen domains,
and if I look at the VirtualBox driver it seems to take care
of domains which are not currently running (or paused).
  Also if we were to implement that restriction it would be
better done in the libvirt.c front-end by asking the driver
if the domin is active and returning directly from there.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/