[libvirt] Re: [virt-tools-list] libvirt 0.7.2 linker issues

[Daniel P. Berrange]

On Mon, Oct 19, 2009 at 11:48:09AM -0600, Jim Fehlig wrote:
> Laurent Léonard wrote:
> > Le lundi 19 octobre 2009 à 15:21, Cole Robinson a écrit :
> >   
> >> On 10/19/2009 08:54 AM, Laurent Léonard wrote:
> 

> commit 1e0ec790a0f1f8b8d54c862db42050a51f62ba61
> Author: Jim Fehlig <jfehlig at novell.com>
> Date:   Mon Oct 19 11:45:19 2009 -0600
> 
>     Add selinux CFLAGS and linker flags to security driver
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index d0ef7d1..8e27ea7 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -657,6 +657,8 @@ libvirt_driver_security_la_CFLAGS = \
>  libvirt_driver_security_la_LDFLAGS =
>  if WITH_SECDRIVER_SELINUX
>  libvirt_driver_security_la_SOURCES += $(SECURITY_DRIVER_SELINUX_SOURCES)
> +libvirt_driver_security_la_CFLAGS += $(SELINUX_CFLAGS)
> +libvirt_driver_security_la_LDFLAGS += $(SELINUX_LIBS)
>  endif
>  if WITH_SECDRIVER_APPARMOR
>  libvirt_driver_security_la_SOURCES += $(SECURITY_DRIVER_APPARMOR_SOURCES)

ACK, this is correct.


I can't help wondering if we need it against libvirt_driver_storage_la
too, since that links to selinux routines too



Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|