[libvirt] [PATCH] node_device_conf.c: remove dead initialization

Daniel P. Berrange berrange at redhat.com
Thu Sep 3 11:58:45 UTC 2009


On Thu, Sep 03, 2009 at 01:40:29PM +0200, Jim Meyering wrote:
> The following use of "caps" is the assignment in a for-loop,
> so the initialization is unnecessary.
> 
> 
> >From 7032a0b370db1a9489cf19fce0cabbb6959320ab Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering at redhat.com>
> Date: Thu, 3 Sep 2009 13:38:57 +0200
> Subject: [PATCH] node_device_conf.c: remove dead initialization
> 
> * src/node_device_conf.c (virNodeDeviceDefFormat): Remove dead
> initialization.
> ---
>  src/node_device_conf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/node_device_conf.c b/src/node_device_conf.c
> index 56a9bb5..5b25bb7 100644
> --- a/src/node_device_conf.c
> +++ b/src/node_device_conf.c
> @@ -213,7 +213,7 @@ char *virNodeDeviceDefFormat(virConnectPtr conn,
>                               const virNodeDeviceDefPtr def)
>  {
>      virBuffer buf = VIR_BUFFER_INITIALIZER;
> -    virNodeDevCapsDefPtr caps = def->caps;
> +    virNodeDevCapsDefPtr caps;
>      char *tmp;
> 
>      virBufferAddLit(&buf, "<device>\n");

ACK

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list