[libvirt] [PATCH] virsh: schedinfo --set invalid=value would simply ignore the option
Eric Blake
eblake at redhat.com
Tue May 11 14:21:14 UTC 2010
On 05/11/2010 08:00 AM, Jim Meyering wrote:
> Currently, virsh does this:
>
> $ virsh -c test:///default schedinfo 1 --set j=k>/dev/null && echo bad
> bad
>
> It should have diagnosed "j=k" as an invalid schedinfo --set argument.
> +
> +: ${srcdir=$(pwd)}
As long as we are assuming a modern shell with $() support, can't we
also assume that $PWD is reliable and save a fork?
At any rate, ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100511/b47be663/attachment-0001.sig>
More information about the libvir-list
mailing list