[libvirt] [PATCH] qemu: Allow using regular audio backends with VNC

Eric Blake eblake at redhat.com
Thu May 20 19:20:48 UTC 2010


On 05/20/2010 10:04 AM, Cole Robinson wrote:
> Currently all host audio backends are disabled if a VM is using VNC, in
> favor of the QEMU VNC audio extension. Unfortunately no released VNC
> client supports this extension, so users have no way of getting audio
> to work if using VNC.
> 
> Add a new config option in qemu.conf which allows changing libvirt's
> behavior, but keep the default intact.

Typos to fix:

> +# QEMU implements anextension for providing audio over a VNC connection,

s/anextension/an extension/

> @@ -4394,12 +4398,15 @@ int qemudBuildCommandLine(virConnectPtr conn,
>              ADD_ARG_LIT(def->graphics[0]->data.vnc.keymap);
>          }
>  
> -        /* QEMU implements a VNC extension for providing audio, so we
> -         * set the audio backend to none, to prevent it opening the
> -         * host OS audio devices since that causes security issues
> -         * and is non-sensical when using VNC.
> +        /* Unless user requested it, set the audio backend to none, to
> +         * prevent it opening the host OS audio devices since that causes

s/devices/devices,/

> +         * security issues and is may not work when using VNC.

s/is may/might/

ACK with those changes.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100520/950cfc8c/attachment-0001.sig>


More information about the libvir-list mailing list