[libvirt] [PATCH 2/3] storage: Combine some duplicate code
Eric Blake
eblake at redhat.com
Thu May 20 22:16:31 UTC 2010
On 05/20/2010 01:23 PM, Cole Robinson wrote:
> Volume detection in the scsi backend was duplicating code already
> present in storage_backend.c. Let's drop the duplicate code.
>
> Also, change the shared function name to be less generic, and remove
> some error squashing in the other call site.
>
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> src/storage/storage_backend.c | 4 ++--
> src/storage/storage_backend.h | 4 ++--
> src/storage/storage_backend_mpath.c | 2 +-
> src/storage/storage_backend_scsi.c | 32 ++------------------------------
> 4 files changed, 7 insertions(+), 35 deletions(-)
Nice cleanup. ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100520/76099246/attachment-0001.sig>
More information about the libvir-list
mailing list