[libvirt] [PATCH v5] dots should be valid characters in interface names

Charles Duffy Charles_Duffy at messageone.com
Thu May 20 22:11:34 UTC 2010


On 05/20/2010 04:45 PM, Eric Blake wrote:
> On 05/20/2010 03:06 PM, Charles Duffy wrote:
>>> Charles, Laine, what do you think about just removing this check
>>> completely?
>>
>> WORKSFORME as well.
>>
>> I'm presuming that it's still appropriate to check against an empty
>> string. Does the attached look right? If so, I'll update the associated
>> RHEL6 ticket [https://bugzilla.redhat.com/show_bug.cgi?id=593907]
>> appropriately.
>
> Looks like Chris posted a similar patch, but I like yours better.  But
> why the additional inclusion of "c-ctype.h"?

Accidental -- updated patch attached -- though I'm perfectly happy with 
Chris's version too (though it probably ought to clean up the now-unused 
VALID_IFNAME_CHARS).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-allow_dots_in_ifnames-r5.patch
Type: text/x-patch
Size: 1411 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100520/04436c28/attachment-0001.bin>


More information about the libvir-list mailing list