Re: [libvirt] [PATCH] network: bridge: Don't start network if it collides with host routing

[Cole Robinson <crobinso redhat com>]

On 05/21/2010 01:35 PM, Laine Stump wrote:
> I'm stepping back, for now, on my suggestion of using libnl to do this. 
> The proposed method works, and solves a serious problem. Using libnl 
> would also work, but would create a new dependency (which can be a bit 
> hairy with libnl - eg RHEL5 has libnl-1.0 which is API-incompatible with 
> libnl-1.1, and can't be installed in parallel), and would take longer to 
> get right.

...

> 
> ACK, modulo the error message typo and the use of sscanf, and with a 
> note somewhere that we should refine the check later to possibly take 
> into account route netmasks and gateways, and host interface addresses 
> (we need to be careful not to put in too much restriction, and kill 
> useful configurations, so I think we should take time to think about it 
> before acting further).
> 

Thanks for the feedback, resending shortly with your comments addressed.

- Cole