[libvirt] [PATCH v4] storage: Sanitize pool target paths
Eric Blake
eblake at redhat.com
Tue May 25 16:09:34 UTC 2010
On 05/25/2010 09:49 AM, Cole Robinson wrote:
> Spurious / in a pool target path makes life difficult for apps using the
> GetVolByPath, and doing other path based comparisons with pools. This
> has caused a few issues for virt-manager users:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=494005
> https://bugzilla.redhat.com/show_bug.cgi?id=593565
>
> Add a new util API which removes spurious /, virFileSanitizePath. Sanitize
> target paths when parsing pool XML, and for paths passed to GetVolByPath.
>
> v2: Leading // must be preserved, properly sanitize path=/, sanitize
> away /./ -> /
>
> v3: Properly handle starting ./ and ending /.
>
> v4: Drop all '.' handling, just sanitize / for now.
ACK - by simplifying the function, it's simpler to verify by code
inspection. Thanks for the repeated attempts at this.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100525/fa6b1989/attachment-0001.sig>
More information about the libvir-list
mailing list