Re: [libvirt] [PATCH] Use printf instead of echo -e in libvirt.spec.in

[Matthias Bolte <matthias bolte googlemail com>]

2010/5/27 Eric Blake <eblake redhat com>:
> On 05/26/2010 03:57 PM, Matthias Bolte wrote:
>> make rpm created dummy tests containing '-e #!/bin/sh' for me.
>> ---
>>  libvirt.spec.in |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/libvirt.spec.in b/libvirt.spec.in
>> index 20ccfda..09f554e 100644
>> --- a/libvirt.spec.in
>> +++ b/libvirt.spec.in
>> @@ -658,7 +658,7 @@ cd tests
>>  for i in nodeinfotest daemon-conf seclabeltest
>>  do
>>    rm -f $i
>> -  echo -e "#!/bin/sh\nexit 0" > $i
>> +  printf "#!/bin/sh\nexit 0" > $i
>
> printf "#!/bin/sh\nexit 0\n" > $i
>
> ACK with that tweak (we _want_ the trailing newline that echo gave us
> for free).
>

Ah, okay. I added the \n and pushed it.

Matthias