[libvirt] [PATCH 1/3] spec: always autoreconf when building rpm

Eric Blake eblake at redhat.com
Mon Dec 5 17:38:49 UTC 2011


Over time, Fedora and RHEL RPMs have often backported upstream
patches that touched configure.ac and/or Makefile.am; this
necessitates rerunning the autotools for the patch to be effective.
Making this part of the spec file will make it easier for future
backports to pull patches without thinking about this issue.

* libvirt.spec.in (BuildRequires): Add autotools.
(%build): Use them before configure.
---
 libvirt.spec.in |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 06c949b..462421a 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -334,6 +334,9 @@ Requires: libcgroup
 %endif

 # All build-time requirements
+BuildRequires: autoconf
+BuildRequires: automake
+BuildRequires: libtool
 BuildRequires: python-devel
 %if %{with_systemd}
 BuildRequires: systemd-units
@@ -721,6 +724,7 @@ of recent versions of Linux (and other OSes).
 %define init_scripts --with-init_script=redhat
 %endif

+autoreconf -if
 %configure %{?_without_xen} \
            %{?_without_qemu} \
            %{?_without_openvz} \
-- 
1.7.7.3




More information about the libvir-list mailing list