[libvirt] [PATCH] qemu: Reject SDL graphic if it's not supported by qemu

Osier Yang jyang at redhat.com
Wed Jan 12 08:58:00 UTC 2011


于 2011年01月11日 23:33, Eric Blake 写道:
> On 01/11/2011 04:29 AM, Daniel P. Berrange wrote:
>> On Tue, Jan 11, 2011 at 03:43:07PM +0800, Osier Yang wrote:
>>> If the emulator doesn't support SDL graphic, we should reject
>>> the use of SDL graphic xml with error messages, but not ignore
>>> it silently.
>>>
>>> * src/qemu/qemu_command.c
>>
>> NACK.
>>
>> Most previous versions of QEMU don't have any explicit -sdl
>> flag. You got SDL automagically when *no* -vnc flag was
>> given. So this change breaks many old QEMU versions.
>
> We should know (or be able to find out) the precise version of qemu
> where sdl was added as an explicit device.  Once we do that, it's easy
> enough to modify libvirt's qemu/qemu_capabilities.h to add yet another
> flag bit, and qemu_capabilities.c to set that flag bit to true for old
> versions where SDL is automatic, and to new versions where SDL is
> explicitly available, while leaving it false on new versions (such as
> the RHEL build) where SDL is disabled.
>
> I agree that it doesn't scale well for other features with similar
> treatments, but the entire qemu_capabilities.c file is an example of the
> effect of poor scalability of upstream qemu.
>

[root at Osier qemu]# git log 7d957bd8cbcbf56f7916d375e65042d767f544b5
commit 7d957bd8cbcbf56f7916d375e65042d767f544b5
Author: aliguori <aliguori at c046a42c-6fe2-441c-8c8c-71466251a162>
Date:   Thu Jan 15 22:14:11 2009 +0000

     DisplayState interface change (Stefano Stabellini)

[root at Osier qemu]# git log VERSION
<split>
commit b4171e4b79d5be97ee0d1516aab321f32a3aca1a
Author: aliguori <aliguori at c046a42c-6fe2-441c-8c8c-71466251a162>
Date:   Wed Mar 4 22:47:59 2009 +0000

     Add version information for 0.10.0 release.

     Signed-off-by: Anthony Liguori <aliguori at us.ibm.com>



     git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6685 
c046a42c-6fe2-441c-8c8c-71466251a162

diff --git a/VERSION b/VERSION
index f514a2f..78bc1ab 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-0.9.1
\ No newline at end of file
+0.10.0

commit bfe312121eb80226f0cb2d4b7c2b9b5fafecd93e
Author: bellard <bellard at c046a42c-6fe2-441c-8c8c-71466251a162>
Date:   Sun Jan 6 17:10:54 2008 +0000

     version change


     git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@3892 
c046a42c-6fe2-441c-8c8c-71466251a162
</split>

so, it should be from 0.10.0

Regards
Osier




More information about the libvir-list mailing list