[libvirt] [PATCH] remote/ssh: support for no_verify.
Matthias Bolte
matthias.bolte at googlemail.com
Sun Jul 3 08:38:03 UTC 2011
2011/7/2 Oskari Saarenmaa <os at ohmu.fi>:
> Set StrictHostKeyChecking=no to auto-accept new ssh host keys if the
> no_verify extra parameter was specified. This won't disable host key
> checking for already known hosts.
> ---
> src/remote/remote_driver.c | 1 +
> src/rpc/virnetclient.c | 3 ++-
> src/rpc/virnetclient.h | 1 +
> src/rpc/virnetsocket.c | 3 +++
> src/rpc/virnetsocket.h | 1 +
> tests/virnetsockettest.c | 2 ++
> 6 files changed, 10 insertions(+), 1 deletions(-)
> @@ -596,6 +597,8 @@ int virNetSocketNewConnectSSH(const char *nodename,
> if (noTTY)
> virCommandAddArgList(cmd, "-T", "-o", "BatchMode=yes",
> "-e", "none", NULL);
> + if (noVerify)
> + virCommandAddArgList(cmd, "-oStrictHostKeyChecking=no", NULL);
This should be virCommandAddArgList(cmd, "-o",
"StrictHostKeyChecking=no", NULL); to match the style of the noTTY
option.
The patch looks okay, but is incomplete. It needs to mention that
no_verify now works for ssh too in docs/remote.html.in and
virnetsockettest.c needs an additional test case for ssh+no_verify
like the test case for shh+no_tty (SSH test 2).
--
Matthias Bolte
http://photron.blogspot.com
More information about the libvir-list
mailing list