Re: [libvirt] [PATCH 0/8] more coverity cleanups

[Daniel Veillard <veillard redhat com>]

On Fri, Jul 01, 2011 at 05:35:58PM -0600, Eric Blake wrote:
> Many are minor (silencing warnings or only affect OOM), but at least
> patch 5/8 is a real bug that needs to be fixed pre-release.
> 
> Eric Blake (8):
>   rpc: avoid memory leak on error
>   qemu: silence coverity warnings
>   rpc: silence coverity warning
>   cgroup: silence coverity warning
>   rpc: fix logic bug
>   qemu: avoid null deref on low memory
>   vmware: avoid null deref on failed lookup
>   storage: avoid crash on parse error
> 
>  src/qemu/qemu_audit.c               |    6 ++++--
>  src/qemu/qemu_command.c             |    6 +++++-
>  src/qemu/qemu_domain.c              |    4 ++--
>  src/qemu/qemu_migration.c           |    3 ++-
>  src/rpc/virnetclient.c              |    3 ++-
>  src/rpc/virnetserverclient.c        |    1 +
>  src/rpc/virnetserverservice.c       |    7 ++++++-
>  src/storage/storage_backend_iscsi.c |   14 ++++++++++----
>  src/util/cgroup.c                   |    2 +-
>  src/vmware/vmware_driver.c          |    2 +-
>  10 files changed, 34 insertions(+), 14 deletions(-)

  Okay, I applied that patch set. I just had to review 1/8 and 8/8
a bit deeper since they are not obvious, but looks fine, ACK

  thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/