[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/10] qemu: check flags in qemuDomainGetXMLDesc



On Tue, Jul 05, 2011 at 03:45:50AM -0400, Laine Stump wrote:
> Although most functions with flags check to verify no application is
> passing in flag bits that are currently undefined, for some reason
> this function wasn't.
> ---
>  src/qemu/qemu_driver.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 363a361..8105910 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -3825,6 +3825,10 @@ static char *qemuDomainGetXMLDesc(virDomainPtr dom,
>      unsigned long balloon;
>      int err;
>  
> +    virCheckFlags(VIR_DOMAIN_XML_SECURE |
> +                  VIR_DOMAIN_XML_INACTIVE |
> +                  VIR_DOMAIN_XML_UPDATE_CPU, NULL);
> +
>      qemuDriverLock(driver);
>      vm = virDomainFindByUUID(&driver->domains, dom->uuid);

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]