[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/20] drivers: prefer unsigned int for flags



On Wed, Jul 06, 2011 at 05:23:46PM -0600, Eric Blake wrote:
> Now that the public APIs always use unsigned flags, the internal
> driver callbacks might as well do likewise.
> 
> * src/driver.h (vrDrvOpen, virDrvDomainCoreDump)
> (virDrvDomainGetXMLDesc, virDrvNetworkGetXMLDesc)
> (virDrvNWFilterGetXMLDesc): Update type.
> * src/remote/remote_protocol.x (remote_open_args)
> (remote_domain_core_dump_args, remote_domain_get_xml_desc_args)
> (remote_network_get_xml_desc_args)
> (remote_nwfilter_get_xml_desc_args): Likewise.
> * src/test/test_driver.c: Update clients.
> * src/remote/remote_driver.c: Likewise.
> * src/xen/xen_hypervisor.c: Likewise.
> * src/xen/xen_hypervisor.h: Likewise.
> * src/xen/xen_driver.c: Likewise.
> * src/xen/xend_internal.c: Likewise.
> * src/xen/xend_internal.h: Likewise.
> * src/xen/xm_internal.c: Likewise.
> * src/xen/xm_internal.h: Likewise.
> * src/xen/xs_internal.c: Likewise.
> * src/xen/xs_internal.h: Likewise.
> * src/xen/xen_inotify.c: Likewise.
> * src/xen/xen_inotify.h: Likewise.
> * src/phyp/phyp_driver.c: Likewise.
> * src/openvz/openvz_driver.c: Likewise.
> * src/vmware/vmware_driver.c: Likewise.
> * src/vbox/vbox_driver.c: Likewise.
> * src/vbox/vbox_tmpl.c: Likewise.
> * src/xenapi/xenapi_driver.c: Likewise.
> * src/esx/esx_driver.c: Likewise.
> * src/esx/esx_interface_driver.c: Likewise.
> * src/esx/esx_network_driver.c: Likewise.
> * src/esx/esx_storage_driver.c: Likewise.
> * src/esx/esx_device_monitor.c: Likewise.
> * src/esx/esx_secret_driver.c: Likewise.
> * src/esx/esx_nwfilter_driver.c: Likewise.
> * src/interface/netcf_driver.c: Likewise.
> * src/nwfilter/nwfilter_driver.c: Likewise.
> * src/libxl/libxl_driver.c: Likewise.
> * src/qemu/qemu_driver.c: Likewise.
> * src/lxc/lxc_driver.c: Likewise.
> * src/uml/uml_driver.c: Likewise.
> * src/network/bridge_driver.c: Likewise.
> * src/secret/secret_driver.c: Likewise.
> * src/storage/storage_driver.c: Likewise.
> * src/node_device/node_device_hal.c: Likewise.
> * src/node_device/node_device_udev.c: Likewise.
> * src/remote_protocol-structs: Likewise.
> ---
>  src/driver.h                       |   10 +++++-----
>  src/esx/esx_device_monitor.c       |    4 ++--
>  src/esx/esx_driver.c               |    5 +++--
>  src/esx/esx_interface_driver.c     |    4 ++--
>  src/esx/esx_network_driver.c       |    4 ++--
>  src/esx/esx_nwfilter_driver.c      |    3 ++-
>  src/esx/esx_secret_driver.c        |    4 ++--
>  src/esx/esx_storage_driver.c       |    4 ++--
>  src/interface/netcf_driver.c       |    4 ++--
>  src/libxl/libxl_driver.c           |    6 +++---
>  src/lxc/lxc_driver.c               |    4 ++--
>  src/network/bridge_driver.c        |    6 ++++--
>  src/node_device/node_device_hal.c  |    3 ++-
>  src/node_device/node_device_udev.c |    2 +-
>  src/nwfilter/nwfilter_driver.c     |    8 +++++---
>  src/openvz/openvz_driver.c         |    4 ++--
>  src/phyp/phyp_driver.c             |    6 +++---
>  src/qemu/qemu_driver.c             |    8 +++++---
>  src/remote/remote_driver.c         |   24 +++++++++++++++---------
>  src/remote/remote_protocol.x       |   10 +++++-----
>  src/remote_protocol-structs        |   10 +++++-----
>  src/secret/secret_driver.c         |    2 +-
>  src/storage/storage_driver.c       |    2 +-
>  src/test/test_driver.c             |   24 +++++++++++++-----------
>  src/uml/uml_driver.c               |    4 ++--
>  src/vbox/vbox_driver.c             |    4 ++--
>  src/vbox/vbox_tmpl.c               |   11 ++++++-----
>  src/vmware/vmware_driver.c         |    4 ++--
>  src/xen/xen_driver.c               |    6 +++---
>  src/xen/xen_hypervisor.c           |    2 +-
>  src/xen/xen_hypervisor.h           |    2 +-
>  src/xen/xen_inotify.c              |    6 +++---
>  src/xen/xen_inotify.h              |    3 ++-
>  src/xen/xend_internal.c            |    4 ++--
>  src/xen/xend_internal.h            |    5 +++--
>  src/xen/xm_internal.c              |    2 +-
>  src/xen/xm_internal.h              |    5 +++--
>  src/xen/xs_internal.c              |    4 ++--
>  src/xen/xs_internal.h              |    4 ++--
>  src/xenapi/xenapi_driver.c         |    5 +++--
>  40 files changed, 127 insertions(+), 105 deletions(-)

  Painfully long, but right

> diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs
> index 25979b4..b2de8e9 100644
> --- a/src/remote_protocol-structs
> +++ b/src/remote_protocol-structs
> @@ -81,7 +81,7 @@ struct remote_node_get_memory_stats {
>  };
>  struct remote_open_args {
>          remote_string              name;
> -        int                        flags;
> +        u_int                      flags;
>  };
>  struct remote_supports_feature_args {
>          int                        feature;
> @@ -422,7 +422,7 @@ struct remote_domain_restore_args {
>  struct remote_domain_core_dump_args {
>          remote_nonnull_domain      dom;
>          remote_nonnull_string      to;
> -        int                        flags;
> +        u_int                      flags;
>  };
>  struct remote_domain_screenshot_args {
>          remote_nonnull_domain      dom;
> @@ -434,7 +434,7 @@ struct remote_domain_screenshot_ret {
>  };
>  struct remote_domain_get_xml_desc_args {
>          remote_nonnull_domain      dom;
> -        int                        flags;
> +        u_int                      flags;
>  };
>  struct remote_domain_get_xml_desc_ret {
>          remote_nonnull_string      xml;
> @@ -726,7 +726,7 @@ struct remote_network_destroy_args {
>  };
>  struct remote_network_get_xml_desc_args {
>          remote_nonnull_network     net;
> -        int                        flags;
> +        u_int                      flags;
>  };
>  struct remote_network_get_xml_desc_ret {
>          remote_nonnull_string      xml;
> @@ -782,7 +782,7 @@ struct remote_nwfilter_undefine_args {
>  };
>  struct remote_nwfilter_get_xml_desc_args {
>          remote_nonnull_nwfilter    nwfilter;
> -        int                        flags;
> +        u_int                      flags;
>  };
>  struct remote_nwfilter_get_xml_desc_ret {
>          remote_nonnull_string      xml;

  Can we triple check that the remote stuff really allocate the same
space for int and u_int, that's my only doubt in that change,

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]