Re: [libvirt] [PATCH 09/20] esx: reject unknown flags

[Daniel Veillard <veillard redhat com>]

On Wed, Jul 06, 2011 at 05:23:52PM -0600, Eric Blake wrote:
> Silently ignored flags get in the way of new features that
> use those flags.
> 
> * src/esx/esx_device_monitor.c (esxDeviceOpen): Reject unknown
> flags.
> * src/esx/esx_driver.c (esxOpen, esxDomainReboot)
> (esxDomainXMLFromNative, esxDomainXMLToNative)
> (esxDomainMigratePrepare, esxDomainMigratePerform)
> (esxDomainMigrateFinish): Likewise.
> * src/esx/esx_interface_driver.c (esxInterfaceOpen): Likewise.
> * src/esx/esx_network_driver.c (esxNetworkOpen): Likewise.
> * src/esx/esx_nwfilter_driver.c (esxNWFilterOpen): Likewise.
> * src/esx/esx_secret_driver.c (esxSecretOpen): Likewise.
> * src/esx/esx_storage_driver.c (esxStorageOpen): Likewise.
> ---
>  src/esx/esx_device_monitor.c   |    4 +++-
>  src/esx/esx_driver.c           |   28 +++++++++++++++++++++-------
>  src/esx/esx_interface_driver.c |    4 +++-
>  src/esx/esx_network_driver.c   |    4 +++-
>  src/esx/esx_nwfilter_driver.c  |    4 +++-
>  src/esx/esx_secret_driver.c    |    4 +++-
>  src/esx/esx_storage_driver.c   |    4 +++-
>  7 files changed, 39 insertions(+), 13 deletions(-)
> 

  ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/