[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/14] Ensure signal handler propagates fatal signals to default handler



On 07/07/2011 08:17 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> When replacing the default SEGV/ABORT/BUS signal handlers you
> can't rely on the process being terminated after your custom
> handler runs. It is neccessary to manually restore the default

s/neccessary/necessary/

> handler and then re-raise the signal
> 
> * src/rpc/virnetserver.c: Restore default handler and raise
>   signal
> ---
>  src/rpc/virnetserver.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

ACK.

There's a gnulib module for raise() which we are not using, but that
module says it is only needed for _really_ old platforms (even mingw
already has raise), so I don't think we need to worry about using it.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]