[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] 1/3 testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]



On 07/08/2011 07:40 PM, Eric Blake wrote:
>>
>> Instead count from 0 to 39 to fix this.
>> ---
>>  tests/test-lib.sh |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/test-lib.sh b/tests/test-lib.sh
>> index 768f96b..9eb6864 100644
>> --- a/tests/test-lib.sh
>> +++ b/tests/test-lib.sh
>> @@ -54,9 +54,9 @@ test_final()
>>    status=$2
>>  
>>    if test "$verbose" = "0" ; then
>> -    mod=`expr \( $counter + 1 \) % 40`
>> -    if test "$mod" != "0" && test "$mod" != "1" ; then
>> -      for i in `seq $mod 40`
>> +    mod=`expr $counter % 40`
>> +    if test "$mod" != "0" ; then
>> +      for i in `seq $mod 39`
> 
> seq is a GNU-ism, but this is no less portable than what it was before.
>  (To be portable to platforms that lack seq, this should really be
> written as:
> 
> for i in 0 1 2 3 4 ... 39

Why iterate in the first place?

+    if test "$mod" != "0" ; then
+      for i in `seq $mod 39`
       do
         printf " "

can portably be replaced by:

printf "%${len}s" ""

with len computed via expr.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]