[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/19] qemu: Consolidate qemuMigrationPrepare{Direct, Tunnel}



On Fri, Jul 08, 2011 at 01:34:13AM +0200, Jiri Denemark wrote:
> Most of the code in these two functions is supposed to be identical but
> currently it isn't (which is natural since the code is duplicated).
> Let's move common parts of these functions into qemuMigrationPrepareAny.

Were there any actual bugs fixed in this consolidation, or were
the differences in the code just cosmetic ? If so it'd be good to
mention the bugs fixed in the commit message

> ---
>  src/qemu/qemu_migration.c |  255 +++++++++++++++-----------------------------
>  1 files changed, 87 insertions(+), 168 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]