Re: [libvirt] [PATCH v2 0/7] Add support for setting QoS

[Daniel Veillard <veillard redhat com>]

On Tue, Jul 12, 2011 at 01:57:06PM +0200, Michal Privoznik wrote:
> This patch series add support for setting traffic shaping and policing
> on both domain's interface and network's virtual bridge. Basically,
> this is done via 'tc' from iproute2 package. For shaping is HTB used,
> for policing we need u32 match selector. Both should be available in
> RHEL-6 kernel.
> 
> How this works:
> On an virtual interface which has limits defined a root qdisc are replaced.
> Ingress root for outbound traffic shaping and egress for inbound.
> Basically, in inbound traffic policing is applied, on outbound shaping.

  Okay, this should work
  http://events.linuxfoundation.org/events/linuxcon-japan/horman
OpenVSwitch offers both egress and ingress and based on Horman feedback
in slides it wasn't a good idea to use ingress (i.e. traffic shaping)
for inbound but egress was fine (see slides from 18)

> New qdiscs are set to limit the traffic to rate set in XML. For shaping
> it is possible to set the size of buffer. Accepted values for rate, peak
> and burst have same format as 'tc' command and are documented.
> 
> Supported devices are VIR_DOMAIN_NET_TYPE_NETWORK, VIR_DOMAIN_NET_TYPE_BRIDGE
> and VIR_DOMAIN_NET_TYPE_DIRECT.
> 
> diff to v1:
> -rebase to current HEAD
> -add support for macvtap devices

  Okay, individual review separately,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/