[libvirt] [PATCH] Fix build when using polkit0

Jim Fehlig jfehlig at novell.com
Tue Jul 12 14:48:29 UTC 2011


Daniel P. Berrange wrote:
> On Mon, Jul 11, 2011 at 04:16:55PM -0600, Jim Fehlig wrote:
>   
>> Daniel P. Berrange wrote:
>>     
>>> I'd like the virNetServer stuff to not have any mention of policy
>>> kit in it. So rather than saying 'bool usePolkit', have a
>>> 'bool connectDBus', and just remove those HAVE_POLKIT0 conditionals
>>> so that the DBus API is always available in virNetServer. The changes
>>> you made under daemon/ are all fine
>>>   
>>>       
>> The attached patch introduces a HAVE_DBUS conditional, which AFAICT is
>> only used by polkit0 so is only set when polkit0 is detected during
>> configure.  Is this what you had in mind?
>>     
[...]
>
> ACK, this looks fine now
>   

Thanks, pushed.

Regards,
Jim




More information about the libvir-list mailing list