Re: [libvirt] [PATCH 14/14] Enable systemd socket activation with virtlockd

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Jul 07, 2011 at 05:42:01PM +0200, Paolo Bonzini wrote:
> On 07/07/2011 04:17 PM, Daniel P. Berrange wrote:
> >  if [ $1 -eq 1 ] ; then
> >      # Initial installation
> >+    /bin/systemctl enable virtlockd.service>/dev/null 2>&1 || :
> >      /bin/systemctl enable libvirtd.service>/dev/null 2>&1 || :
> >      /bin/systemctl enable cgconfig.service>/dev/null 2>&1 || :
> >  fi
> >@@ -914,8 +915,10 @@ fi
> >  %if %{with_systemd}
> >  if [ $1 -eq 0 ] ; then
> >      # Package removal, not upgrade
> >+    /bin/systemctl --no-reload disable virtlockd.service>  /dev/null 2>&1 || :
> >      /bin/systemctl --no-reload disable libvirtd.service>  /dev/null 2>&1 || :
> >      /bin/systemctl stop libvirtd.service>  /dev/null 2>&1 || :
> >+    /bin/systemctl stop virtlockd.service>  /dev/null 2>&1 || :
> >  fi
> 
> Do you really want to enable the .service by default rather than the
> .socket?  IIUC, in the common case of no autostart guests enabling
> the .socket will cut on boot-time operations.

Yeah, I think you might be right. I'll investigate it further...

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|