Re: [libvirt] [PATCHv2 07/27] storage: reject unknown flags

[Matthias Bolte <matthias bolte googlemail com>]

2011/7/8 Eric Blake <eblake redhat com>:
> * src/storage/storage_backend.c (virStorageBackendCreateBlockFrom)
> (virStorageBackendCreateQemuImg)
> (virStorageBackendCreateQcowCreate): Reject unknown flags.
> * src/storage/storage_backend_disk.c (virStorageBackendDiskBuildPool)
> (virStorageBackendDiskDeleteVol): Likewise.
> * src/storage/storage_backend_fs.c
> (virStorageBackendFileSystemNetFindPoolSources)
> (virStorageBackendFileSystemBuild)
> (virStorageBackendFileSystemDelete, createFileDir)
> (virStorageBackendFileSystemVolBuildFrom)
> (virStorageBackendFileSystemVolDelete): Likewise.
> * src/storage/storage_backend_iscsi.c
> (virStorageBackendISCSIFindPoolSources): Likewise.
> * src/storage/storage_backend_logical.c
> (virStorageBackendLogicalFindPoolSources)
> (virStorageBackendLogicalBuildPool)
> (virStorageBackendLogicalDeletePool)
> (virStorageBackendLogicalDeleteVol): Likewise.
> * src/storage/storage_driver.c (storageOpen, storagePoolCreate)
> (storagePoolDefine, storagePoolRefresh, storagePoolGetXMLDesc)
> (storageVolumeCreateXML, storageVolumeCreateXMLFrom)
> (storageVolumeGetXMLDesc): Likewise.
> ---
>  src/storage/storage_backend.c         |   12 ++++++--
>  src/storage/storage_backend_disk.c    |   10 +++++--
>  src/storage/storage_backend_fs.c      |   26 ++++++++++++++----
>  src/storage/storage_backend_iscsi.c   |    4 ++-
>  src/storage/storage_backend_logical.c |   18 +++++++++---
>  src/storage/storage_driver.c          |   45 ++++++++++++++++++++++++++------
>  6 files changed, 88 insertions(+), 27 deletions(-)

ACK.

-- 
Matthias Bolte
http://photron.blogspot.com