Re: [libvirt] [PATCHv2 10/27] lxc: reject unknown flags

[Matthias Bolte <matthias bolte googlemail com>]

2011/7/8 Eric Blake <eblake redhat com>:
> * src/lxc/lxc_driver.c (lxcOpen, lxcDomainSetMemoryParameters)
> (lxcDomainGetMemoryParameters): Reject unknown flags.
> * src/lxc/lxc_container.c (lxcContainerStart): Use unsigned flags.
> ---
>  src/lxc/lxc_container.c |    4 ++--
>  src/lxc/lxc_driver.c    |   12 +++++++++---
>  2 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
> index ef8469c..ffa2f34 100644
> --- a/src/lxc/lxc_container.c
> +++ b/src/lxc/lxc_container.c
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (C) 2008-2010 Red Hat, Inc.
> + * Copyright (C) 2008-2011 Red Hat, Inc.
>  * Copyright (C) 2008 IBM Corp.
>  *
>  * lxc_container.c: file description
> @@ -889,7 +889,7 @@ int lxcContainerStart(virDomainDefPtr def,
>                       char *ttyPath)
>  {
>     pid_t pid;
> -    int flags;
> +    unsigned int flags;

flags is passed to clone that takes int, so rename this to cflags (in
line with oflags and fflags) and keep it as int.

ACK, with the clone flags as int.

-- 
Matthias Bolte
http://photron.blogspot.com