[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 02/27] maint: print flags in hex during debug



On 07/13/2011 03:49 AM, Matthias Bolte wrote:
> 2011/7/8 Eric Blake <eblake redhat com>:
>> Continuation of commit 313ac7fd, and enforce things with a syntax
>> check.
>>
>> Technically, virNetServerClientCalculateHandleMode is not printing
>> a mode_t, but rather a collection of VIR_EVENT_HANDLE_* bits;
>> however, these bits are < 8, so there is no different in the
>> output, and that was the easiest way to silence the new syntax check.
>>
> 
> flags_debug
> src/libvirt-qemu.c:117:    VIR_DEBUG("conn=%p, pid=%u, flags=%u",
> conn, pid, flags);
> maint.mk: debug flag values with %x
> 
> Dan commited this after you posted your series. So ACK with that new
> offender fix too.

Yep, I noticed that while rebasing as well.

Fixed and pushed, along with patch 1/27.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]