[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Patch 0/3]virsh: Patches for virsh logging



On Thu, Jul 14, 2011 at 12:57:41 +0530, Supriya Kannery wrote:
> On 06/30/2011 01:52 PM, Supriya Kannery wrote:
> > Virsh logging has some basic issues:
> > 1. In code, magic numbers are used for logging rather than loglevel
> >     variables.
> > 2. Magic number "5" is used for logging which doesn't map to any
> >     loglevel variable. Valid loglevel range is 0-4
> > 3. Usage of loglevel variables doesn't align with that of libvirt
> >     logging. In libvirt "DEBUG" loglevel is the superset and logs
> >     messages at all other levels. Whereas in virsh, "ERROR" loglevel
> >     behaves this way, which needs correction
> > 4. virsh man page and code are inconsistent with respect to loglevels
> >
> > Following patchset is to address the above mentioned issues.
> >
> > 1/3 - Avoid using magic numbers for logging
> > 2/3 - Align log level usage to that of libvirt
> > 3/3 - Update virsh manpage with related changes
> >
> > tools/virsh.pod |   30 ++++++++++++
> > tools/virsh.c   |  124 +++++++++++++++++++++++++++---------------------
> > 2 files changed, 102 insertions(+), 52 deletions(-)
> 
> Please review...

Yeah, I started reviewing these yesterday and bumped into make check failures
which I didn't have time to fully investigate yet. Except for some minor
things, the series looks good so far.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]