[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] storage: Avoid memory leak on metadata fetching



On 07/14/2011 08:15 AM, Michal Privoznik wrote:
> Getting metadata on storage allocates a memory (path) which need to
> be freed after use otherwise it gets leaked. This means after use of
> virStorageFileGetMetadataFromFD or virStorageFileGetMetadata one
> must call virStorageFileFreeMetadata to free it. This function frees
> structure internals and structure itself.
> ---
> diff to v2:
> -Jrika's & Eric's review taken in
> 
> diff to v1:
> -Eric's review suggestions taken in
> 
>  cfg.mk                           |    1 +
>  src/conf/domain_conf.c           |   18 +++++++++---
>  src/libvirt_private.syms         |    1 +
>  src/storage/storage_backend_fs.c |   54 +++++++++++++++++++++----------------
>  src/util/storage_file.c          |   18 ++++++++++++
>  src/util/storage_file.h          |    2 +
>  6 files changed, 66 insertions(+), 28 deletions(-)

ACK - looks like you got all my points addressed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]