[libvirt] [PATCH] build: check for virnetprotocol on-the-wire stability

Eric Blake eblake at redhat.com
Thu Jul 14 15:37:10 UTC 2011


On 07/14/2011 09:19 AM, Matthias Bolte wrote:
> 2011/7/13 Eric Blake <eblake at redhat.com>:
>> Similar to the recent qemu_protocol-structs addition.
>>
>> * src/virnetprotocol-structs: New file.
>> * src/Makefile.am (%_protocol-structs): Factor body...
>> (PDWTAGS): ...into new helper macro.
>> (virnetprotocol-structs): New rule.
>> (PROTOCOL_STRUCTS): Add virnetprotocol-structs.
>> ---
>>
>> In reply to:
>> https://www.redhat.com/archives/libvir-list/2011-July/msg00602.html
>>
>>  src/Makefile.am            |   24 +++++++++++++++---------
>>  src/virnetprotocol-structs |   31 +++++++++++++++++++++++++++++++
>>  2 files changed, 46 insertions(+), 9 deletions(-)
>>  create mode 100644 src/virnetprotocol-structs
> 
> Tested, works, ACK.

Thanks; pushed.

Hmm, on looking further, I wonder if we need to also include enums in
the *protocol-structs files.  It looks odd seeing virNetMessageType used
as a field member with no prior declaration - meaning that if someone
botches the enum type, we won't catch that botch.  I'll see about a
followup patch.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110714/40b9ee33/attachment-0001.sig>


More information about the libvir-list mailing list