[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 1/6] flags: use common dumpxml flags check



n 07/14/2011 04:42 PM, Eric Blake wrote:
> The previous patches only cleaned up ATTRIBUTE_UNUSED flags cases;
> auditing the drivers found other places where flags was being used
> but not validated.  In particular, domainGetXMLDesc had issues with
> clients accepting a different set of flags than the common
> virDomainDefFormat helper function.
> 
> * src/conf/domain_conf.c (virDomainDefFormat): Add common flag check.

Ouch, another regression.  virDomainDefFormat is now causing migration
failure, because virDomainObjFormat (called by virDomainSaveStatus) is
passing an internal-only flag.  I'll have a fix for that shortly.  :(

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]