[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 6/8] undefine: Implement undefineFlags in all other drivers



On 07/15/2011 03:06 AM, Osier Yang wrote:
> Add domainUndefineFlags support for these drivers (except qemu and
> libxl driver), and changes domainUndefine as a wrapper of
> domainUndefineFlags, but they actually perform same.
> ---
>  src/esx/esx_driver.c       |   11 ++++++++++-
>  src/lxc/lxc_driver.c       |   11 ++++++++++-
>  src/openvz/openvz_driver.c |   11 ++++++++++-
>  src/test/test_driver.c     |   12 +++++++++++-
>  src/uml/uml_driver.c       |   12 +++++++++++-
>  src/vmware/vmware_driver.c |   12 +++++++++++-
>  src/xen/xen_driver.c       |    9 ++++++++-
>  7 files changed, 71 insertions(+), 7 deletions(-)
> 
> @@ -3329,6 +3332,11 @@ esxDomainUndefine(virDomainPtr domain)
>  }
>  
>  
> +static int
> +esxDomainUndefine(virDomainPtr domain)
> +{
> +    esxDomainUndefineFlags(domain, 0);

Missing a return keyword.  I'm guessing you aren't set up to
compile-test ESX.

ACK with that fixed.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]