[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/7] bandwitdh: Implement functions to enable and disable QoS



On Tue, Jul 12, 2011 at 13:57:11 +0200, Michal Privoznik wrote:
> These function executes 'tc' with appropriate arguments to set
> desired QoS setting on interface or bridge during its creation.
> ---
>  configure.ac                |    4 +
>  src/libvirt_private.syms    |    2 +
>  src/network/bridge_driver.c |   12 +++
>  src/qemu/qemu_command.c     |   10 +++-
>  src/util/macvtap.c          |   12 +++-
>  src/util/macvtap.h          |    5 +-
>  src/util/network.c          |  161 +++++++++++++++++++++++++++++++++++++++++++
>  src/util/network.h          |    3 +
>  8 files changed, 205 insertions(+), 4 deletions(-)

I didn't spot any issues in this patch but I have a general question. Does QoS
state need to be cleaned up in case virBandwidthEnable succeeds but something
further in the process fails? That is do we need to call virBandwidthDisable
in the cleanup part? Similarly, if is any cleanup needed when some parts of
virBandwidthEnable succeeds but not all of them?

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]