[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 18/8] save: support direct flag in libvirt-guests init script



* tools/libvirt-guests.init.sh (start): Use SAVE_DIRECT.
---

Patch 10/8 has a bug fixed here - the code must use $direct rather
than "$direct" so as to elide the argument rather than inject an
empty string argument when the option is not in use.

The more I look at this series, the more I like the idea of adding
both save and restore direct support at the same time, so I'll post
a v2 that rebases things accordingly.

 tools/libvirt-guests.init.sh |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tools/libvirt-guests.init.sh b/tools/libvirt-guests.init.sh
index 4e383c4..7e1dd51 100644
--- a/tools/libvirt-guests.init.sh
+++ b/tools/libvirt-guests.init.sh
@@ -144,6 +144,8 @@ start() {
     fi

     isfirst=true
+    direct=
+    test "x$SAVE_DIRECT" = x0 || direct=--direct
     while read uri list; do
         configured=false
         set -f
@@ -173,7 +175,7 @@ start() {
                     else
                         sleep $START_DELAY
                     fi
-                    retval run_virsh "$uri" start "$name" >/dev/null && \
+                    retval run_virsh "$uri" start $direct "$name" >/dev/null && \
                     gettext "done"; echo
                 fi
             fi
@@ -194,7 +196,7 @@ suspend_guest()
     direct=
     test "x$SAVE_DIRECT" = x0 || direct=--direct
     printf %s "$label"
-    run_virsh "$uri" managedsave "$direct" "$guest" >/dev/null &
+    run_virsh "$uri" managedsave $direct "$guest" >/dev/null &
     virsh_pid=$!
     while true; do
         sleep 1
-- 
1.7.4.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]