[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 8/8] virsh: Extend virsh dominfo to display if managed state exists



On 07/18/2011 11:34 AM, Eric Blake wrote:
Here, we print "managed state", but the command that creates that state
is called "managedsave", and the API we call is
virDomainHasManagedSaveImage. Not to mention that it surpasses 15
columns, which makes the output not lined up with all the other rows.
Also, the "Has" is a bit redundant. I'd prefer to see this output as:

Managed save: yes|no|unknown

ACK with that nit fixed, and this can be pushed independently of the
rest of the series.

Also, squash in some documentation:

diff --git i/tools/virsh.pod w/tools/virsh.pod
index 5afa1f2..312ddf0 100644
--- i/tools/virsh.pod
+++ w/tools/virsh.pod
@@ -514,6 +514,9 @@ Save and destroy (stop) a running domain, so it can be restarted from the same
 state at a later time.  When the virsh B<start> command is next run for
 the domain, it will automatically be started from this saved state.

+The B<dominfo> command can be used to query whether a domain currently
+has any managed save state.
+
 =item B<managedsave-remove> I<domain-id>

 Remove the B<managedsave> state file for a domain, if it exists.  This

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]