[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 4/8] undefine: Implement internal API for qemu driver



On 07/18/2011 01:52 AM, Osier Yang wrote:
* src/qemu/qemu_driver.c: New call back for qemu_driver,
New function qemudDomainUndefineFlags, and changes on
qemudDomainUndefine.
---
  src/qemu/qemu_driver.c |   36 +++++++++++++++++++++++++++++++++++-
  1 files changed, 35 insertions(+), 1 deletions(-)


+qemuDomainUndefineFlags(virDomainPtr dom,
+                         unsigned int flags)
+{
      struct qemud_driver *driver = dom->conn->privateData;
      virDomainObjPtr vm;
      virDomainEventPtr event = NULL;
+    char *name = NULL;
      int ret = -1;

+    virCheckFlags(VIR_DOMAIN_UNDEFINE_MANAGED_STATE, -1);

Still not sure if we should have named the flag VIR_DOMAIN_UNDEFINE_MANAGED_SAVE in patch 2.

But that's a naming nit, with obvious fallout for the entire series if we adjust that name.

ACK to this patch.

--
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]