Re: [libvirt] [libvirt-users] cannot perform tunnelled migration without using peer2peer flag

[Jiri Denemark <jdenemar redhat com>]

On Mon, Jul 18, 2011 at 13:11:42 -0600, Eric Blake wrote:
> On 07/18/2011 04:11 AM, Osier Yang wrote:
> > 于 2011年07月18日 10:07, zhang xintao 写道:
> >> Dear All
> >> I try to migration a kvm guest os to another host failed
> >> server: ubuntu 11.04 server
> >> virsh:migrate --live --tunnelled vm1 qemu+ssh://192.168.10.3/system
> >> error:Requested operation is not valid:cannot perform
> >> tunnelled migration without using peer2peer flag
> >
> > The error tells you all, you need to use "--p2p".
> 
> That said, why can't virsh be smarter, and automatically request the 
> right underlying flags without making the user also type --p2p?  Any 
> problems with this patch?

No problem at all, I think it's a very good idea.

>  From db318d41c2a70189c21303c824aa4a862815874a Mon Sep 17 00:00:00 2001
> From: Eric Blake <eblake redhat com>
> Date: Mon, 18 Jul 2011 13:10:29 -0600
> Subject: [PATCH] virsh: make migrate --tunnelled imply --p2p
> 
> We can make the virsh migrate UI friendlier by supplying the
> missing bit automatically instead of erroring out when requesting
> --tunnelled without --p2p.
> 
> * tools/virsh.c (doMigrate): Make --p2p optional when using
> --tunnelled.
> * tools/virsh.pod (migrate): Tweak wording accordingly.
> ---
>   tools/virsh.c   |    2 +-
>   tools/virsh.pod |    5 +++--
>   2 files changed, 4 insertions(+), 3 deletions(-)

So, here is my ACK

Jirka